Skip to content

Migrate project to AndroidX#27

Merged
wenxi-zeng merged 1 commit into
segment-integrations:masterfrom
scana:maintenance/get-rid-of-old-annotations
Mar 14, 2023
Merged

Migrate project to AndroidX#27
wenxi-zeng merged 1 commit into
segment-integrations:masterfrom
scana:maintenance/get-rid-of-old-annotations

Conversation

@scana

@scana scana commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

No need to keep support-annotations anymore as androidx.annotations offer the same set of annotations.

Will resolve issues like this one:

-> com.segment.analytics.android.integrations:intercom:1.3.0 -> com.android.support:support-annotations:28.0.0
WARNING:Your project has set `android.useAndroidX=true`, but configuration `:somemodule:implementation:releaseRuntimeClasspath` still contains legacy support libraries, which may cause runtime issues.
This behavior will not be allowed in Android Gradle plugin 8.0.

@wenxi-zeng wenxi-zeng merged commit 7d6fb20 into segment-integrations:master Mar 14, 2023
@wenxi-zeng

wenxi-zeng commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

thanks for contributing. looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenxi-zeng wenxi-zeng wenxi-zeng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scana @wenxi-zeng