Skip to content

feat: add support for configuring CDN#407

Closed
yordis wants to merge 1 commit into
segmentio:masterfrom
yordis:add-cdn-url-setting
Closed

feat: add support for configuring CDN#407
yordis wants to merge 1 commit into
segmentio:masterfrom
yordis:add-cdn-url-setting

Conversation

@yordis
Copy link
Copy Markdown
Contributor

@yordis yordis commented Mar 24, 2022

fixes #362

@yordis yordis force-pushed the add-cdn-url-setting branch from c26a790 to 68bb5bf Compare March 24, 2022 03:57
@yordis yordis force-pushed the add-cdn-url-setting branch from 68bb5bf to 914480e Compare March 24, 2022 03:57
@pooyaj pooyaj requested a review from a team March 24, 2022 17:25
@pooyaj
Copy link
Copy Markdown
Contributor

pooyaj commented Mar 24, 2022

awesome! thanks @yordis 🎉 There are few places that we need to propagate the CDN address to as well. For example, when loading destinations/remote-plugins/etc. ... searching the codebase for cdn = window.analytics?._cdn ?? getCDN() will give you pointers to that. Can we update those as well? Happy to tackle internally as well if it looks tedious to support.

@yordis
Copy link
Copy Markdown
Contributor Author

yordis commented Mar 25, 2022

@pooyaj happy to fix everything, I wasn't aware of them. Let me dig into it.

@silesky
Copy link
Copy Markdown
Contributor

silesky commented Mar 29, 2022

@yordis, thank you for your contribution, this is helpful!

If it's OK, I'm continuing your work in this PR #414, and am working to bring it across the finish line. As such, we can probably close this PR.

@yordis
Copy link
Copy Markdown
Contributor Author

yordis commented Mar 30, 2022

@silesky please feel free to take over if you finish first, I don't mind at all, I was about to work on this over the weekend. So if you have bandwidth before, keep going.

@silesky silesky closed this Mar 31, 2022
@silesky silesky reopened this Mar 31, 2022
@silesky
Copy link
Copy Markdown
Contributor

silesky commented Mar 31, 2022

Continued in #414

@silesky silesky closed this Mar 31, 2022
@yordis yordis deleted the add-cdn-url-setting branch March 31, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow cdn in AnalyticsSettings

3 participants