Conversation
The new `make lint` target runs golangci-lint if installed locally. It is not (yet) required for a passing build. Most issues reported by golangci-lint are resolved. Some interesting ones: * Missing error checking is added for exporting to a properties file and to Terraform variables. * Unused functions are removed: stringInSlice, S3KMSStore.readObject. * Unused variables are removed: validKeyFormat. * Write operations used to set up store tests now have their errors checked. If a setup write fails, the test immediately fails. Unresolved issues: * Use of EndpointResolverWithOptions * Missing error checks for flushing, syncing, and closing a file created by the export command
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 35.81% 36.17% +0.35%
==========================================
Files 25 25
Lines 2284 2256 -28
==========================================
- Hits 818 816 -2
+ Misses 1394 1368 -26
Partials 72 72 ☔ View full report in Codecov by Sentry. |
Sabrina0614
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
make linttarget runs golangci-lint if installed locally. Itis not (yet) required for a passing build.
Most issues reported by golangci-lint are resolved. Some interesting
ones:
to Terraform variables.
checked. If a setup write fails, the test immediately fails.
Unresolved issues:
created by the export command