refactor: Switch to AWS endpoint resolution v2#517
Merged
Conversation
The v2 AWS SDK introduces a new endpoint resolution mechanism where custom endpoints are specified on a per-service basis, while the previous global mechanism is deprecated. This changeset switches to the newer mechanism. The default resolver under the new mechanism uses the base endpoint in a service client's `Options` as the means to customize endpoints, so it's enough for tests to make sure the base endpoint gets set. Under the previous mechanism, the CHAMBER_AWS_SSM_ENDPOINT environment variable was used to customize not just the endpoint for SSM, but also for Secrets Manager. This changeset deprecates the latter use in favor of a new CHAMBER_AWS_SECRETS_MANAGER_ENDPOINT environment variable. There seems to also be SDK-native ways to use the environment for endpoint customization, so this whole thing might go away at some point.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #517 +/- ##
==========================================
+ Coverage 35.97% 36.00% +0.02%
==========================================
Files 29 29
Lines 2524 2525 +1
==========================================
+ Hits 908 909 +1
Misses 1538 1538
Partials 78 78 ☔ View full report in Codecov by Sentry. |
Sabrina0614
previously approved these changes
Jun 10, 2024
Contributor
Author
|
I inadvertently left the old resolver in place in shared.go. Fixing! |
Sabrina0614
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2 AWS SDK introduces a new endpoint resolution mechanism where
custom endpoints are specified on a per-service basis, while the
previous global mechanism is deprecated. This changeset switches to the
newer mechanism.
The default resolver under the new mechanism uses the base endpoint in
a service client's
Optionsas the means to customize endpoints, soit's enough for tests to make sure the base endpoint gets set.
Under the previous mechanism, the CHAMBER_AWS_SSM_ENDPOINT environment
variable was used to customize not just the endpoint for SSM, but also
for Secrets Manager. This changeset deprecates the latter use in favor
of a new CHAMBER_AWS_SECRETS_MANAGER_ENDPOINT environment variable.
There seems to also be SDK-native ways to use the environment for
endpoint customization, so this whole thing might go away at some point.