chore: Upgrade to Go 1.21, several AWS dependencies#558
Merged
Conversation
Contributor
Author
|
Ah, the AWS SDK now requires Go 1.21. https://github.com/aws/aws-sdk-go-v2/releases/tag/release-2024-08-15 |
bhavanki
force-pushed
the
aws-dep-upgrades
branch
from
09676b9 to
b636540
Compare
bhavanki
changed the title
bhavanki
force-pushed
the
aws-dep-upgrades
branch
from
b07ba71 to
69f0690
Compare
alecjacobs5401
previously approved these changes
Aug 19, 2024
go.mod
Outdated
| go 1.20 | ||
| go 1.21 | ||
|
|
||
| toolchain go1.21.6 |
Contributor
There was a problem hiding this comment.
open question on this - would we not want this to be the latest go version we are building and running with?
In our Dockerfile, we're using 1.22 still
Line 1 in 58c5ce1
Contributor
Author
There was a problem hiding this comment.
Turns out we don't need the toolchain line. go mod tidy added it, I suppose based on what I have locally, but go get toolchain@none(ref) removed it, and everything still seems OK.
Contributor
Author
There was a problem hiding this comment.
Oh, as for the Dockerfile, dependabot is already on it: https://github.com/segmentio/chamber/pull/557/files
bhavanki
force-pushed
the
aws-dep-upgrades
branch
from
69f0690 to
9d40ec3
Compare
alecjacobs5401
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I filed this as an alternative to five other dependabot PRs, and to investigate why they were failing. Once this one is merged, those other PRs will become obsolete.
The root problem discovered here is that the AWS SDK just increased its minimum Go version to 1.21. Chamber may do the same, since it only supports the most recent two Go versions. Although 1.21 is now the third most recent, we'll leave it in since it can at least build.
#559 also groups future aws-sdk-go-v2 upgrades into single PRs, for easier review and more efficient use of GitHub resources.