fix(flatkv): prevent phantom MixOut for new accounts in LtHash#3000
Open
blindchaser wants to merge 4 commits intomainfrom
Open
fix(flatkv): prevent phantom MixOut for new accounts in LtHash#3000blindchaser wants to merge 4 commits intomainfrom
blindchaser wants to merge 4 commits intomainfrom
Conversation
When a new account (not in accountDB) was first written,
getAccountValue returned a zero AccountValue{}. Encoding it produced
40 zero-bytes (len>0), so LtHash performed a MixOut on data that was
never MixIn'd, corrupting the hash
Replace oldAccountValues (map[string]AccountValue) with
oldAccountRawValues (map[string][]byte) that stores raw DB bytes.
Accounts not found in DB get nil, and LtHash correctly skips MixOut
when len(LastValue)==0
Tests:
- Add lthash_correctness_test.go with 100-block end-to-end test
verifying incremental LtHash matches full-scan at every checkpoint
- Add focused regression tests for new-account phantom MixOut and
multi-ApplyChangeSets-per-block scenarios
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3000 +/- ##
==========================================
- Coverage 58.30% 58.30% -0.01%
==========================================
Files 2108 2108
Lines 173668 173648 -20
==========================================
- Hits 101259 101238 -21
- Misses 63389 63392 +3
+ Partials 9020 9018 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change