Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
app/seidb.go
Outdated
| scConfig.MemIAVLConfig.SnapshotWriterLimit = cast.ToInt(appOpts.Get(FlagSCSnapshotWriterLimit)) | ||
| scConfig.MemIAVLConfig.SnapshotPrefetchThreshold = cast.ToFloat64(appOpts.Get(FlagSCSnapshotPrefetchThreshold)) | ||
| scConfig.MemIAVLConfig.SnapshotWriteRateMBps = cast.ToInt(appOpts.Get(FlagSCSnapshotWriteRateMBps)) | ||
| scConfig.WriteMode = config.WriteMode(cast.ToString(appOpts.Get(FlagSCWriteMode))) |
There was a problem hiding this comment.
considering learning from ss config parsing string: only overwrite if non-empty, validate, and panic on invalid values
if wm := cast.ToString(appOpts.Get(FlagEVMSSWriteMode)); wm != "" {
parsedWM, err := config.ParseWriteMode(wm)
if err != nil {
panic(fmt.Sprintf("invalid EVM SS write mode %q: %s", wm, err))
}
ssConfig.WriteMode = parsedWM
}
if rm := cast.ToString(appOpts.Get(FlagEVMSSReadMode)); rm != "" {
parsedRM, err := config.ParseReadMode(rm)
if err != nil {
panic(fmt.Sprintf("invalid EVM SS read mode %q: %s", rm, err))
}
ssConfig.ReadMode = parsedRM
}
|
|
||
| // Other configs | ||
| FlagSnapshotInterval = "state-sync.snapshot-interval" | ||
| FlagMigrateIAVL = "migrate-iavl" |
There was a problem hiding this comment.
in cmd/seid/cmd/root.go -> addModuleInitFlags(), --migrate-iavl and --migrate-height CLI flags orphaned
There was a problem hiding this comment.
Good call, removing
| FlagSCEnable = "state-commit.sc-enable" | ||
| FlagSCDirectory = "state-commit.sc-directory" | ||
| FlagSCAsyncCommitBuffer = "state-commit.sc-async-commit-buffer" | ||
| FlagSCZeroCopy = "state-commit.sc-zero-copy" |
There was a problem hiding this comment.
docker config files (docker/localnode/config/app.toml, docker/rpcnode/config/app.toml) still reference sc-zero-copy and sc-cache-size. these are likely pre-existing and out of scope for this PR, but worth noting for cleanup
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3002 +/- ##
==========================================
- Coverage 58.30% 58.30% -0.01%
==========================================
Files 2108 2108
Lines 173672 173675 +3
==========================================
- Hits 101262 101261 -1
- Misses 63390 63393 +3
- Partials 9020 9021 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Describe your changes and provide context
Add flags/opts to allow setting dual write and dual read for SC, remove migration flag as well
Testing performed to validate your change
Tested on RPC node