Skip to content

Update Recorder Mode and Refresh Dependencies #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdmintz merged 6 commits into from
Jun 24, 2023
Merged

Update Recorder Mode and Refresh Dependencies #1923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25a725d
Fix a bug with Recorder Mode
mdmintz Jun 24, 2023
3a7b57c
Refactor self.fail() and set a default message
mdmintz Jun 24, 2023
f4eed20
Refresh mkdocs dependencies
mdmintz Jun 24, 2023
1f21520
Update the Wordle example test
mdmintz Jun 24, 2023
5d4a161
Refresh Python dependencies
mdmintz Jun 24, 2023
7b0493f
Bump version to 4.15.5
mdmintz Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/wordle_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ def test_wordle(self):
found_word = False
for attempt in range(6):
num_attempts += 1
if len(self.word_list) == 0:
self.fail("Today's word was not found in my dictionary!")
word = random.choice(self.word_list)
letters = []
for letter in word:
Expand Down
2 changes: 1 addition & 1 deletion mkdocs_build/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ cssselect2==0.7.0
tinycss2==1.2.1
defusedxml==0.7.1
mkdocs==1.4.3
mkdocs-material==9.1.16
mkdocs-material==9.1.17
mkdocs-exclude-search==0.6.5
mkdocs-simple-hooks==0.1.5
mkdocs-material-extensions==1.1.1
8 changes: 4 additions & 4 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ packaging>=23.1;python_version>="3.7"
setuptools>=59.6.0;python_version<"3.7"
setuptools>=68.0.0;python_version>="3.7"
keyring>=23.4.1;python_version<"3.8"
keyring>=24.0.1;python_version>="3.8"
keyring>=24.1.1;python_version>="3.8"
tomli>=1.2.3;python_version<"3.7"
tomli>=2.0.1;python_version>="3.7"
tqdm>=4.64.1;python_version<"3.7"
Expand All @@ -19,7 +19,7 @@ certifi>=2023.5.7
filelock>=3.4.1;python_version<"3.7"
filelock>=3.12.2;python_version>="3.7"
platformdirs>=2.4.0;python_version<"3.7"
platformdirs>=3.7.0;python_version>="3.7"
platformdirs>=3.8.0;python_version>="3.7"
parse>=1.19.1
pyparsing>=3.0.7;python_version<"3.7"
pyparsing>=3.1.0;python_version>="3.7"
Expand All @@ -34,7 +34,7 @@ chardet==5.1.0;python_version>="3.7"
charset-normalizer==2.0.12;python_version<"3.7"
charset-normalizer==3.1.0;python_version>="3.7"
urllib3==1.26.12;python_version<"3.7"
urllib3>=1.26.15,<2.1.0;python_version>="3.7"
urllib3>=1.26.16,<2.1.0;python_version>="3.7"
requests==2.27.1;python_version<"3.7"
requests==2.31.0;python_version>="3.7"
requests-toolbelt==1.0.0
Expand All @@ -61,7 +61,7 @@ pluggy==1.0.0;python_version<"3.7"
pluggy==1.2.0;python_version>="3.7"
py==1.11.0
pytest==7.0.1;python_version<"3.7"
pytest==7.3.2;python_version>="3.7"
pytest==7.4.0;python_version>="3.7"
pytest-forked==1.4.0;python_version<"3.7"
pytest-forked==1.6.0;python_version>="3.7"
pytest-html==2.0.1
Expand Down
2 changes: 1 addition & 1 deletion seleniumbase/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# seleniumbase package
__version__ = "4.15.4"
__version__ = "4.15.5"
8 changes: 8 additions & 0 deletions seleniumbase/console_scripts/sb_mkrec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,14 @@ def main():
run_cmd = "%s -m pytest %s --rec -q -s --url=%s" % (
sys.executable, file_name, start_page
)
if '"' not in start_page:
run_cmd = '%s -m pytest %s --rec -q -s --url="%s"' % (
sys.executable, file_name, start_page
)
elif "'" not in start_page:
run_cmd = "%s -m pytest %s --rec -q -s --url='%s'" % (
sys.executable, file_name, start_page
)
if use_edge:
run_cmd += " --edge"
if force_gui:
Expand Down
10 changes: 10 additions & 0 deletions seleniumbase/console_scripts/sb_recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,16 @@ def do_recording(file_name, url, overwrite_enabled, use_chrome, window):
"%s -m seleniumbase mkrec %s --url=%s --gui"
% (sys.executable, file_name, url)
)
if '"' not in url:
command = (
'%s -m seleniumbase mkrec %s --url="%s" --gui'
% (sys.executable, file_name, url)
)
elif "'" not in url:
command = (
"%s -m seleniumbase mkrec %s --url='%s' --gui"
% (sys.executable, file_name, url)
)
if not use_chrome:
command += " --edge"
if (
Expand Down
4 changes: 2 additions & 2 deletions seleniumbase/fixtures/base_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7667,9 +7667,9 @@ def reset_default_timeout(self):
sb_config._is_timeout_changed = False
self.__overrided_default_timeouts = False

def fail(self, msg=None):
def fail(self, msg="fail() called!"):
"""Fail immediately, with the given message."""
super().fail(msg)
raise self.failureException(msg)

def skip(self, reason=""):
"""Mark the test as Skipped."""
Expand Down
8 changes: 4 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
'setuptools>=59.6.0;python_version<"3.7"',
'setuptools>=68.0.0;python_version>="3.7"',
'keyring>=23.4.1;python_version<"3.8"',
'keyring>=24.0.1;python_version>="3.8"',
'keyring>=24.1.1;python_version>="3.8"',
'tomli>=1.2.3;python_version<"3.7"',
'tomli>=2.0.1;python_version>="3.7"',
'tqdm>=4.64.1;python_version<"3.7"',
Expand All @@ -145,7 +145,7 @@
'filelock>=3.4.1;python_version<"3.7"',
'filelock>=3.12.2;python_version>="3.7"',
'platformdirs>=2.4.0;python_version<"3.7"',
'platformdirs>=3.7.0;python_version>="3.7"',
'platformdirs>=3.8.0;python_version>="3.7"',
'parse>=1.19.1',
'pyparsing>=3.0.7;python_version<"3.7"',
'pyparsing>=3.1.0;python_version>="3.7"',
Expand All @@ -160,7 +160,7 @@
'charset-normalizer==2.0.12;python_version<"3.7"',
'charset-normalizer==3.1.0;python_version>="3.7"',
'urllib3==1.26.12;python_version<"3.7"',
'urllib3>=1.26.15,<2.1.0;python_version>="3.7"',
'urllib3>=1.26.16,<2.1.0;python_version>="3.7"',
'requests==2.27.1;python_version<"3.7"',
'requests==2.31.0;python_version>="3.7"',
'requests-toolbelt==1.0.0',
Expand All @@ -187,7 +187,7 @@
'pluggy==1.2.0;python_version>="3.7"',
"py==1.11.0",
'pytest==7.0.1;python_version<"3.7"',
'pytest==7.3.2;python_version>="3.7"',
'pytest==7.4.0;python_version>="3.7"',
'pytest-forked==1.4.0;python_version<"3.7"',
'pytest-forked==1.6.0;python_version>="3.7"',
"pytest-html==2.0.1", # Newer ones had issues
Expand Down