Skip to content

Regression: computed property brackets removed from tokenHeader in v13.3.1, breaking authentication #955

@iuliancristea

Description

@iuliancristea

Description

Commit 146c351 (included in v13.3.1) removed computed property brackets from tokenHeader across all files that make HTTP
requests. This breaks authentication because tokenHeader is a variable holding "PRIVATE-TOKEN" or "JOB-TOKEN", not a
literal header name.

Before (v13.3.0)

headers: { [tokenHeader]: gitlabToken }
// Sends: PRIVATE-TOKEN: glpat-xxx

After (v13.3.1)

headers: { tokenHeader: gitlabToken }
// Sends: tokenHeader: glpat-xxx

Without the brackets, JavaScript treats tokenHeader as a literal property name rather than evaluating the variable. The
GitLab API never receives the PRIVATE-TOKEN (or JOB-TOKEN) header, so requests to private projects return 404, which the
plugin maps to EMISSINGREPO.

@candrews

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions