[WIP] Add whitelabeling helpers#306
Conversation
thinkingserious
added
the
status: code review request
|
|
devchas
added
difficulty: hard
thinkingserious
added
status: hacktoberfest approved
and removed
status: work in progress
|
Hello @bigblind, |
|
Hello @bigblind, |
childish-sambino
removed
the
type: twilio enhancement
thinkingserious
left a comment
thinkingserious
left a comment
There was a problem hiding this comment.
Thank you for the PR, we appreciate it!
| @@ -0,0 +1,141 @@ | |||
| package whitelabel | |||
There was a problem hiding this comment.
We have updated the verbiage used to describe a "whitelabel". Please update accordingly. See this PR for an example.
| return &Client{request} | ||
| } | ||
|
|
||
| // DefaultClient is used if no custom HTTP client is defined |
There was a problem hiding this comment.
I think you should be able to remove the following functions, as they now reside here: https://github.com/sendgrid/sendgrid-go/blob/main/base_interface.go
| return &Client{request} | ||
| } | ||
|
|
||
| // NewClientForEndpoint returns a client that can send requests to a specific endpoint. |
There was a problem hiding this comment.
Why do we need this function, why not just use the default client?
thinkingserious
added
status: waiting for feedback
|
Hello @bigblind, Would you like to continue working on this PR? If not, please let us know and we will add it to our backlog. With best regards, Elmer |
|
Closing until PR feedback is addressed. |
5 participants
Fixes #174
Checklist
Short description of what this PR does:
Add helpers for whitelabeling domains.
This is a work in progress, but I'm already submitting a PR to get some early feedback. Is this what you had in mind to solve the issue?
The issue also mentioned an option to email the DNS records that need to be created, so I'm planning to just add a function called
SendDNSRecordsthat takes an email address to send from, an address to send to, and a slice ofDNSRecords.