Skip to content

test: split up unit and integ tests#1029

Merged
childish-sambino merged 1 commit intomainfrom
split-unit-integ-tests
Dec 14, 2021
Merged

test: split up unit and integ tests#1029
childish-sambino merged 1 commit intomainfrom
split-unit-integ-tests

Conversation

@childish-sambino
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread Makefile

test-integ: test
. venv/bin/activate; coverage run -m unittest discover
. venv/bin/activate; coverage run -m unittest discover -s test/integ
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does test-integ also run the unit tests? Shouldn't it only depend on test-install?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought it would be nice to run both since the unit tests are pretty quick, plus the docker-test workflow calls make test-integ so it will run the unit tests too.

@childish-sambino childish-sambino merged commit 1dcc378 into main Dec 14, 2021
@childish-sambino childish-sambino deleted the split-unit-integ-tests branch December 14, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants