Skip to content

delete PULL_REQUEST_TEMPLATE#506

Merged
mbernier merged 1 commit intosendgrid:masterfrom
thepriefy:patch-1
Dec 12, 2017
Merged

delete PULL_REQUEST_TEMPLATE#506
mbernier merged 1 commit intosendgrid:masterfrom
thepriefy:patch-1

Conversation

@thepriefy
Copy link
Copy Markdown
Contributor

@thepriefy thepriefy commented Oct 30, 2017

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • It should be in .github folder which is already exist.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

It should be in .github folder which is already exist.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 30, 2017

Codecov Report

Merging #506 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #506   +/-   ##
=====================================
  Coverage      83%    83%           
=====================================
  Files          30     30           
  Lines        1024   1024           
  Branches      160    160           
=====================================
  Hits          850    850           
  Misses         84     84           
  Partials       90     90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3283c27...3bfff19. Read the comment docs.

@mbernier mbernier merged commit 7ef8e42 into sendgrid:master Dec 12, 2017
@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @thepriefy,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@mbernier mbernier added the difficulty: easy fix is easy in difficulty label Dec 12, 2017
@thepriefy thepriefy deleted the patch-1 branch December 12, 2017 16:12
@thinkingserious
Copy link
Copy Markdown
Contributor

Duplicate of #505

@thinkingserious thinkingserious marked this as a duplicate of #505 Jun 7, 2018
@thinkingserious thinkingserious added status: duplicate duplicate issue and removed difficulty: easy fix is easy in difficulty hacktoberfest status: code review request requesting a community code review or review from Twilio labels Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: duplicate duplicate issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants