Skip to content

Add unittesting support to .codeclimate.yml#537

Merged
thinkingserious merged 2 commits intosendgrid:masterfrom
prashuchaudhary:patch-1
Jun 6, 2018
Merged

Add unittesting support to .codeclimate.yml#537
thinkingserious merged 2 commits intosendgrid:masterfrom
prashuchaudhary:patch-1

Conversation

@prashuchaudhary
Copy link
Copy Markdown
Contributor

@prashuchaudhary prashuchaudhary commented Nov 1, 2017 •
edited
Loading

Closes #465

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Added Unit Testing using Code Climate config in Travis

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@prashuchaudhary prashuchaudhary mentioned this pull request Nov 1, 2017
Closed
@prashuchaudhary
Copy link
Copy Markdown
Contributor Author

prashuchaudhary commented Nov 1, 2017 •
edited
Loading

@mbernier new pull request for adding code climate unit testing config. closed the previous one. too messy

@prashuchaudhary
Copy link
Copy Markdown
Contributor Author

prashuchaudhary commented Nov 1, 2017

@mbernier Now Code Climate is running unittests and 4 of them are failing.

image

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Feb 27, 2018
@thinkingserious thinkingserious merged commit a1a69d3 into sendgrid:master Jun 6, 2018
@thinkingserious
Copy link
Copy Markdown
Contributor

thinkingserious commented Jun 6, 2018

Hello @prashuchaudhary,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add unittesting support to .codeclimate.yml

3 participants

@prashuchaudhary @thinkingserious @mbernier