Skip to content

master: Add support for Python 3.7#615

Closed
hugovk wants to merge 69 commits intosendgrid:v4from
hugovk:add-3.7
Closed

master: Add support for Python 3.7#615
hugovk wants to merge 69 commits intosendgrid:v4from
hugovk:add-3.7

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented Oct 1, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 1, 2018
@SendGridDX
Copy link
Copy Markdown

SendGridDX commented Oct 1, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 1, 2018

Codecov Report

Merging #615 into v4 will increase coverage by 0.39%.
The diff coverage is 74.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4     #615      +/-   ##
==========================================
+ Coverage   84.38%   84.77%   +0.39%     
==========================================
  Files          37       35       -2     
  Lines         967     1156     +189     
  Branches      108      172      +64     
==========================================
+ Hits          816      980     +164     
+ Misses         93       90       -3     
- Partials       58       86      +28
Impacted Files Coverage Δ
sendgrid/helpers/mail/personalization.py 93.25% <100%> (+0.2%) ⬆️
sendgrid/version.py 100% <100%> (ø) ⬆️
sendgrid/helpers/stats/__init__.py 100% <100%> (ø)
sendgrid/helpers/endpoints/ip/unassigned.py 15% <15%> (ø)
sendgrid/helpers/mail/mail.py 93.71% <50%> (-6.29%) ⬇️
sendgrid/helpers/stats/stats.py 82.19% <82.19%> (ø)
sendgrid/helpers/mail/__init__.py 100% <0%> (ø) ⬆️
sendgrid/helpers/mail/validators.py 44.44% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6326325...42a6728. Read the comment docs.

Comment thread setup.py Outdated
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 2, 2018
@thinkingserious thinkingserious added hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: waiting for feedback waiting for feedback from the submitter labels Oct 5, 2018
@thinkingserious
Copy link
Copy Markdown
Contributor

Hello @hugovk,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Copy Markdown
Contributor

Can you please move this to the v4 branch? Thanks!

@hugovk hugovk changed the base branch from master to v4 October 5, 2018 08:23
@hugovk hugovk mentioned this pull request Oct 5, 2018
6 tasks
@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented Oct 5, 2018

Changing the base branch didn't work very smoothly! Closing this in favour of #637.

@hugovk hugovk closed this Oct 5, 2018
@hugovk hugovk deleted the add-3.7 branch October 5, 2018 08:43
@hugovk hugovk changed the title Add support for Python 3.7 master: Add support for Python 3.7 Oct 5, 2018
@thinkingserious thinkingserious added invalid and removed difficulty: medium fix is medium in difficulty hacktoberfest status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap labels Oct 11, 2018
@hugovk hugovk mentioned this pull request Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.