chore: Clean up sendgrid.py#844
Merged
childish-sambino merged 2 commits intosendgrid:masterfrom Feb 26, 2020
Merged
Conversation
Minor Change
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
==========================================
+ Coverage 80.02% 82.41% +2.38%
==========================================
Files 70 70
Lines 2018 2303 +285
Branches 339 338 -1
==========================================
+ Hits 1615 1898 +283
- Misses 204 206 +2
Partials 199 199
Continue to review full report at Codecov.
|
| import python_http_client | ||
|
|
||
|
|
||
| class SendGridAPIClient(object): |
There was a problem hiding this comment.
if you'll use a good linter like python-black. It'll automatically handle all these things and also the two-line gap before python classes are best practices. You may have a look at other files too.
childish-sambino
approved these changes
Feb 26, 2020
Contributor
Contributor
Author
|
Hello @thinkingserious Thanks for merging my PR and your appreciation. I've filled out the form. Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor Change
Fixes #X
Checklist
Short description of what this PR does:
If you have questions, please send an email to Twilio SendGrid, or file a GitHub Issue in this repository.