Fixes #3266: Incorrect begin/end of alignment for banded alignment #3269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the sequences are sliced by cutting off a prefix of the original seuence due to the band configuration, the relative positions of the sliced sequences was reported inside of the alignment result. However, this slicing happens only internally and thus the positions reported should correspond to the ones of the original sequences. We fix this by tracking the offset of the prefix that was cut off and add this to the relative positions during result creation to get the absolute positions.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eseiler
approved these changes
Jul 16, 2024
Member
eseiler
left a comment
eseiler
left a comment
There was a problem hiding this comment.
Small stuff, you can squash merge if my comments are fine
include/seqan3/alignment/pairwise/policy/alignment_matrix_policy.hpp
Outdated
Show resolved
Hide resolved
include/seqan3/alignment/pairwise/policy/alignment_matrix_policy.hpp
Outdated
Show resolved
Hide resolved
seqan-actions
added
lint
Contributor
Author
|
Thanks a lot for fixing the small stuff right away. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the sequences are sliced by cutting off a prefix of the original seuence due to the band configuration, the relative positions of the sliced sequences was reported inside of the alignment result.
However, this slicing happens only internally and thus the positions reported should correspond to the ones of the original sequences.
We fix this by tracking the offset of the prefix that was cut off and add this to the relative positions during result creation to get the absolute positions.