[INFRA] Rename build_system to cmake #3292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seqan-actions
added
lint
Member
|
Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3292 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 271 271
Lines 11955 11955
Branches 104 104
=======================================
Hits 11732 11732
Misses 223 223 ☔ View full report in Codecov by Sentry. |
seqan-actions
added
lint
seqan-actions
added
lint
SGSSGene
requested changes
Oct 23, 2024
Contributor
SGSSGene
left a comment
SGSSGene
left a comment
There was a problem hiding this comment.
There are two comments from, I believe, the old times, that have got lost and shouldn't be.
test/api_stability/CMakeLists.txt
Outdated
| -DCMAKE_CXX_FLAGS=${SEQAN3_API_STABILITY_CXX_FLAGS} | ||
| -DCMAKE_CXX_COMPILER_LAUNCHER=${CMAKE_CXX_COMPILER_LAUNCHER} | ||
| -DCMAKE_PREFIX_PATH=${CMAKE_CURRENT_LIST_DIR}/../../build_system # use current build_system | ||
| -DCMAKE_PREFIX_PATH=${CMAKE_CURRENT_LIST_DIR}/../../cmake # use current cmake |
Contributor
There was a problem hiding this comment.
This comment is confusing
|
|
||
| # add seqan3 to search path | ||
| list (APPEND CMAKE_PREFIX_PATH "${CMAKE_CURRENT_SOURCE_DIR}/submodules/seqan3/build_system") # change this value | ||
| list (APPEND CMAKE_PREFIX_PATH "${CMAKE_CURRENT_SOURCE_DIR}/submodules/seqan3/cmake") # change this value |
Contributor
There was a problem hiding this comment.
Confusing comment, why should this value be changed?
Member
Author
There was a problem hiding this comment.
It might have been a snippet in the tutorial, but it isn't anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.