Conversation
WikiRik
requested changes
Mar 4, 2023
Member
WikiRik
left a comment
WikiRik
left a comment
There was a problem hiding this comment.
Since this we've brought back the usage of CLS. Can you update that?
6 tasks
Member
|
I forgot about this one, should we revisit this after #330 ? (I'll finish the review of the associations folder soon) Also with sequelize/sequelize#16143 being merged now. |
Member
Author
|
Sure! I'll update it with the new info once the main PR is merged |
Member
Author
|
@WikiRik CI fails due to an issue with our Netlify deployment that I have not inspected, but the PR is ready to review |
Member
|
It seems to have deployed fine; https://64989bbcdd20973b67da64a0--sequelize-site.netlify.app/ |
WikiRik
approved these changes
Jun 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A branch I wrote a while ago but apparently never sent?
This documents the changes made in Sequelize 7 regarding transactions