Add assertions to rcl wrapper#106
Merged
m-dahl merged 2 commits intosequenceplanner:masterfrom Oct 12, 2024
Merged
Conversation
tobiasstarkwayve
force-pushed
the
add-assertions-to-rcl-wrapper
branch
from
511e1b1 to
c8b5e95
Compare
tobiasstarkwayve
force-pushed
the
add-assertions-to-rcl-wrapper
branch
from
c8b5e95 to
d2aa689
Compare
Contributor
Author
|
@m-dahl I just realised that I forgot to ping you here. Could you take a look at this minor change in the RCL bindings? |
Collaborator
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few minor asserts and improvements to the RCL layer. Specifically:
nullchecks in the graph introspection code. Introspection is not particularly performance-critical, I suspect that it's worthwhile to add these checks rather than risk undefined behaviourcopytocopy_nonoverlapping. There is no reason not to do it and it might provide a slight speedup.