Implement rcl_interfaces::srv::ListParameters service#64
Merged
m-dahl merged 1 commit intosequenceplanner:masterfrom Sep 7, 2023
Merged
Implement rcl_interfaces::srv::ListParameters service#64m-dahl merged 1 commit intosequenceplanner:masterfrom
m-dahl merged 1 commit intosequenceplanner:masterfrom
Conversation
With this, one can list node parameters by `ros2 param list`. It also allows modifying the parameters with rig_reconfigure [1]. Without this change, none of these was possible. The functionality should match the corresponding code from rclcpp [2]. Note that `ros2 param list --param-type` and `ros2 param describe` still doesn't work, because it needs `rcl_interfaces::srv::DescribeParameters` to be implemented. [1]: https://github.com/teamspatzenhirn/rig_reconfigure [2]: https://github.com/ros2/rclcpp/blob/689e510cf0d58257752127750b6460f1f66872c5/rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp#L922-L964
Collaborator
|
Looks good! Thank you for the contribution. Do you want me to make a release which includes this, or are you planning on doing more work wrt parameters soon? If so we can wait a bit with a release. |
Contributor
Author
|
Hi, I don't need a release immediately. I'm thinking about implementing a derive macro for parameter structures, but I've never implemented derive macros, so I'm not sure how much time I'll need (and I'm also busy with other stuff). If I don't send further PRs in upcomming weeks, feel free to make a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, one can list node parameters by
ros2 param list. It also allows modifying the parameters with rig_reconfigure 1. Without this change, none of these was possible.The functionality should match the corresponding code from rclcpp 2.
Note that
ros2 param list --param-typeandros2 param describestill doesn't work, because it needsrcl_interfaces::srv::DescribeParametersto be implemented.