Add aws-kotlin-jvm-maven template#4220
Add aws-kotlin-jvm-maven template#4220pmuens merged 4 commits intoserverless:masterfrom RafalWilinski:aws-kotlin-template
Conversation
pmuens
left a comment
There was a problem hiding this comment.
Great addition @RafalWilinski 👍
Just added a comment about the template naming. Haven't tested it yet, but will do so in the upcoming days.
There are still some other things which needs to be added / updated. Best way to find them is to run a global search for aws-python3.
Let us know if you need any help here 💪
| 'aws-groovy-gradle', | ||
| 'aws-java-maven', | ||
| 'aws-java-gradle', | ||
| 'aws-kotlin-jvm-maven', |
There was a problem hiding this comment.
The current naming convention is provider-language/runtime-buildenv.
Maybe we should rename the template to aws-kotlin-maven (since AFAIK AWS uses the jvm behind the scenes)?
There was a problem hiding this comment.
I've added JVM part because Kotlin can compile to Java (JVM) or JS (Node.js). In future, I wanted to add also Kotlin -> JS, hence the name. Node.js option might be even more viable because of much faster initial start time vs JVM.
|
Thanks for review. I totally overlooked other things, sorry for that! Fix incoming |
|
@RafalWilinski thanks a lot for that! Does this template work with your Invoke Local Java PR? Looks good 👍 Nothing to add 😊 |
|
Yes, It works with |
pmuens
left a comment
There was a problem hiding this comment.
Thanks for updating the PR @RafalWilinski 👍
Just tested this template today and it's working great 💪! Good job 💯 (as usual!) --> Merging ![]()
BTW @RafalWilinski that would be super nice ☝️ 💯 |
What did you implement:
Closes #3883
Adds Kotlin template. It uses JVM and Maven under the hood. Support for gradle based is coming soon.
I'm also willing to investigate Kotlin -> JS compilation so it might run using
node6.10runtime.How can we verify it:
serverless create -t aws-kotlin-jvm-mavenserverless deployIt's also compatible with #4199 so you can use
invoke localtoo.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO