Skip to content

Fix incorrect EnumMember value for Yaml - #497

Merged
cdavernas merged 1 commit into
serverlessworkflow:mainfrom
aweng126:fix-enum-value
Feb 24, 2025
Merged

Fix incorrect EnumMember value for Yaml#497
cdavernas merged 1 commit into
serverlessworkflow:mainfrom
aweng126:fix-enum-value

Conversation

@aweng126

Copy link
Copy Markdown
Contributor

Fix incorrect EnumMember value for Yaml

The EnumMember value for 'Yaml' was incorrectly set to 'json'. This PR fixes it to 'yaml' for correct serialization/deserialization.

Fixes #496

@JBBianchi

Copy link
Copy Markdown
Member

Thanks for your contribution @aweng126 , good catch!

However, signing-off the commits is mandatory for the PR to be merged. Could you please proceed ?

Signed-off-by: Li Qingwen <kingwensli@gmail.com>
@aweng126

aweng126 commented Feb 24, 2025

Copy link
Copy Markdown
Contributor Author

@cdavernas @JBBianchi please review the new commit.

@cdavernas cdavernas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@cdavernas
cdavernas merged commit eb26e52 into serverlessworkflow:main Feb 24, 2025
@aweng126
aweng126 deleted the fix-enum-value branch February 24, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: runner Concerns the Runner type: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EnumMember Value for 'Yaml' is Incorrect

3 participants