SES - 4683 : UI Artifact When Opening New Conversation#1628
Merged
jbsession merged 8 commits intosession-foundation:devfrom Oct 23, 2025
Merged
SES - 4683 : UI Artifact When Opening New Conversation#1628jbsession merged 8 commits intosession-foundation:devfrom
jbsession merged 8 commits intosession-foundation:devfrom
Conversation
jbsession
requested review from
SessionHero01 and
ThomasSession
and removed request for
ThomasSession
| } | ||
| ) | ||
|
|
||
| ViewCompat.setOnApplyWindowInsetsListener(binding.newConversationButton) { view, insets -> |
Collaborator
There was a problem hiding this comment.
Why did this have to be done separately instead of in the alsoApply above, which is there to deal with extra elements like this?
Collaborator
Author
There was a problem hiding this comment.
The newConversationButton doesn't want to move with the IME inset so these two needs different typemasks. I added a commit that updates applySafeInsetsMargins to take an optional param for insets that we can use as offsets and used it on newConversationButton.
ThomasSession
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SES-4683
This PR removes IME insets from the new message FAB. The view is not really "squashed" but rather we can see the FAB above the IME when we type from the Start conversation bottom sheet.
ui_fab.mov