Clean up push registration retry logic#1826
Merged
SessionHero01 merged 8 commits intofeature/onion-request-refactorfrom Jan 14, 2026
Merged
Clean up push registration retry logic#1826SessionHero01 merged 8 commits intofeature/onion-request-refactorfrom
SessionHero01 merged 8 commits intofeature/onion-request-refactorfrom
Conversation
…into feature/onion-request-refactor
…into feature/onion-request-refactor # Conflicts: # app/src/main/java/org/session/libsession/messaging/sending_receiving/notifications/PushRegistryV1.kt # app/src/main/java/org/thoughtcrime/securesms/configs/ConfigToDatabaseSync.kt
…into feature/onion-request-refactor
…into feature/onion-request-refactor
|
|
||
| val apiResponseIterator = apiResponses.iterator() | ||
|
|
||
| intermediateResults.forEachIndexed { idx, result -> |
Collaborator
There was a problem hiding this comment.
If we get fewer results than expected from the server, isn't it possible to misalign the results?
Collaborator
Author
There was a problem hiding this comment.
the server MUST give us exactly the same number of result back, otherwise we have no way to know if a request is success or not. Think of it this way: we send an array of request to the server, you'd expect to get the same sized array back, it is an assumption that we have made prior to the network refactoring.
Collaborator
Author
There was a problem hiding this comment.
I will add an explicit check for this server behavior and we will reject the whole call if the server is naughty
ThomasSession
approved these changes
Jan 14, 2026
SessionHero01
merged commit f394159
into
feature/onion-request-refactor
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.