Skip to content

Fix giphy not being able to send and a crash sending quote #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasSession merged 3 commits into from
Feb 16, 2026
Merged

Fix giphy not being able to send and a crash sending quote #1950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65c5c2b
Fix emoji not being able to send and a crash sending quote
SessionHero01 Feb 16, 2026
83a5cf2
Comment
SessionHero01 Feb 16, 2026
f28f16b
Merge branch 'dev' into fix-emoji
SessionHero01 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/src/main/java/org/session/libsession/messaging/messages/visible/Quote.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
package org.session.libsession.messaging.messages.visible

import androidx.annotation.Keep
import org.session.libsession.messaging.MessagingModuleConfiguration
import org.session.libsession.messaging.sending_receiving.attachments.DatabaseAttachment
import org.session.libsession.messaging.sending_receiving.quotes.QuoteModel as SignalQuote
import org.session.protos.SessionProtos
import org.session.libsignal.utilities.Log

class Quote() {
class Quote
// R8: Must keep constructor for Kryo to work
@Keep constructor() {
var timestamp: Long? = 0
var publicKey: String? = null
var text: String? = null
Expand All @@ -17,7 +20,7 @@ class Quote() {
companion object {
const val TAG = "Quote"

fun fromProto(proto: SessionProtos.DataMessage.Quote): Quote? {
fun fromProto(proto: SessionProtos.DataMessage.Quote): Quote {
val timestamp = proto.id
val publicKey = proto.author
val text = proto.text
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/org/thoughtcrime/securesms/providers/BlobUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public static boolean isAuthority(@NonNull Uri uri) {
@WorkerThread
@NonNull
private static CompletableFuture<Uri> writeBlobSpecToDisk(@NonNull Context context, @NonNull BlobSpec blobSpec, @Nullable ErrorListener errorListener) throws IOException {
AttachmentSecret attachmentSecret = ((ApplicationContext) context).getAttachmentSecretProvider().getOrCreateAttachmentSecret();
AttachmentSecret attachmentSecret = ((ApplicationContext) context.getApplicationContext()).getAttachmentSecretProvider().getOrCreateAttachmentSecret();
String directory = getDirectory(blobSpec.getStorageType());
File outputFile = new File(getOrCreateCacheDirectory(context, directory), buildFileName(blobSpec.id));
OutputStream outputStream = ModernEncryptingPartOutputStream.createFor(attachmentSecret, outputFile, true).second;
Expand Down