Replace finl_unicode with unicode-properties#9
Merged
Conversation
LecrisUT
commented
May 8, 2024
Contributor
Author
|
Another alternative we were discussing is |
Owner
|
Sure, switching to unicode_properties seems fine to me. |
LecrisUT
force-pushed
the
remove_dependence
branch
from
a7f1ed0 to
7ccf2fc
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
LecrisUT
force-pushed
the
remove_dependence
branch
from
7ccf2fc to
a7b404d
Compare
LecrisUT
changed the title
finl_unicode dependencefinl_unicode with unicode-properties
Contributor
Author
|
Ok, this seems to work, at least w.r.t. to the tests. Do you want to review this? |
Owner
|
Thanks, sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are trying to package this project on Fedora, but we are encountering some licensing issues with
finl_unicodepackaging. Digging a bit deeper I find it odd that this package would be dependent onfinlpackage. Trying to remove this dependence, I've found that there are only 2 functions that are actually used, and I would like to ask for some feedback if these could be replaced with some more standard functions