-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Open
Description
Checklist
- If this is not a feature request but a general question, please start a discussion at https://github.com/sgl-project/sglang/discussions. Otherwise, it will be closed.
- Please use English. Otherwise, it will be closed.
Motivation
Recently, the SHA256 checksum has been a powerful tool to verify whether the weights have been correctly updated and remain bit-for-bit identical to the target state. @dreamyang-liu
Currently, SGLang supports three major weight refit strategies for RL systems:
- update_weights_from_disk
- update_weights_from_tensor
- update_weights_from_distributed
However, the existing unit tests for these interfaces could be more robust. We believe using SHA256 to verify the weight buffers after refitting will provide a much stricter guarantee of correctness, preventing silent mismatches in RL rollout and training loops.
In this sense, we can try to:
- Refactor LLM Refit Tests: Rewrite the unit tests for the three LLM refit interfaces using SHA256 verification.
- Correctness Guarantee: Ensure that after any refit operation, the in-memory weights match the source perfectly.
Related resources
https://docs.sglang.io/advanced_features/sglang_for_rl.html#open-to-use-refit-functionality
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels