Skip to content

Add yeahdongcn to CI permissions#17667

Merged
Kangyan-Zhou merged 1 commit intosgl-project:mainfrom
yeahdongcn:xd/ci-permissions
Jan 24, 2026
Merged

Add yeahdongcn to CI permissions#17667
Kangyan-Zhou merged 1 commit intosgl-project:mainfrom
yeahdongcn:xd/ci-permissions

Conversation

@yeahdongcn
Copy link
Collaborator

Motivation

Add github user yeahdongcn to CI permissions list.

Modifications

Update CI_PERMISSIONS.json.

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yeahdongcn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to integrate a new contributor, 'yeahdongcn', into the project's development workflow by granting them necessary Continuous Integration permissions. This change enables the user to manage and trigger CI processes, which is crucial for efficient code development and testing within the repository.

Highlights

  • New User CI Permissions: Added the GitHub user 'yeahdongcn' to the CI permissions list, granting them the ability to interact with the Continuous Integration system.
  • Granted CI Capabilities: The user 'yeahdongcn' now has permissions to tag and run CI labels, rerun failed CI jobs, and rerun specific CI stages, with no cooldown period.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new user, yeahdongcn, to the CI permissions list. The change is straightforward and correctly formatted. I have one suggestion to improve the maintainability of the CI_PERMISSIONS.json file by sorting the keys within the new user's entry alphabetically. This will enhance consistency across the large configuration file.

Comment on lines +990 to +994
"can_tag_run_ci_label": true,
"can_rerun_failed_ci": true,
"cooldown_interval_minutes": 0,
"reason": "custom override",
"can_rerun_stage": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and consistency in this large configuration file, it's good practice to keep the keys within each user's permission object sorted alphabetically. While not functionally required, it makes the file easier to read and compare entries.

Suggested change
"can_tag_run_ci_label": true,
"can_rerun_failed_ci": true,
"cooldown_interval_minutes": 0,
"reason": "custom override",
"can_rerun_stage": true
"can_rerun_failed_ci": true,
"can_rerun_stage": true,
"can_tag_run_ci_label": true,
"cooldown_interval_minutes": 0,
"reason": "custom override"

@Kangyan-Zhou Kangyan-Zhou merged commit e1833c4 into sgl-project:main Jan 24, 2026
49 checks passed
Johnsonms pushed a commit to Johnsonms/sglang that referenced this pull request Feb 14, 2026
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants