Skip to content

Add an all type in pyproject.tml to include diffusion support#17697

Merged
Kangyan-Zhou merged 2 commits intosgl-project:mainfrom
Kangyan-Zhou:diffusion_docker_image
Jan 25, 2026
Merged

Add an all type in pyproject.tml to include diffusion support#17697
Kangyan-Zhou merged 2 commits intosgl-project:mainfrom
Kangyan-Zhou:diffusion_docker_image

Conversation

@Kangyan-Zhou
Copy link
Collaborator

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Kangyan-Zhou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new 'all' extra dependency group within the pyproject.toml file. This addition aims to streamline the installation process for users who require a full suite of SGLang functionalities, specifically bundling support for checkpoint-engine, diffusion, and tracing into a single, convenient optional dependency.

Highlights

  • New 'all' dependency group: A new optional dependency group named 'all' has been added to pyproject.toml.
  • Diffusion support inclusion: This new 'all' group includes sglang[diffusion], sglang[checkpoint-engine], and sglang[tracing], making it easier to install a comprehensive set of SGLang features, including diffusion support.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 25, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a convenient [all] optional dependency group to pyproject.toml, which bundles the checkpoint-engine, diffusion, and tracing extras. This is a good addition for user convenience. My review includes one suggestion to ensure the checkpoint-engine extra is complete and aligns with the project's documentation, which is important for users installing via the new [all] group. As a minor note, there's a typo in the pull request title (.tml instead of .toml).

dev = ["sglang[test]"]

all = [
"sglang[checkpoint-engine]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The [checkpoint-engine] extra installs checkpoint-engine==0.1.2. However, the documentation in docs/advanced_features/checkpoint_engine.md consistently recommends installing 'checkpoint-engine[p2p]' to enable all features, particularly for multi-node setups. To ensure users of the new [all] extra get the complete functionality, I recommend updating the checkpoint-engine optional dependency on line 86 to checkpoint-engine = ["checkpoint-engine[p2p]==0.1.2"].

@Kangyan-Zhou Kangyan-Zhou merged commit 8d3e1ac into sgl-project:main Jan 25, 2026
63 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant