Skip to content

fix: move nightly whl to cuda version folder#17762

Merged
Fridge003 merged 3 commits intomainfrom
move-nightly-whl-to-location
Jan 26, 2026
Merged

fix: move nightly whl to cuda version folder#17762
Fridge003 merged 3 commits intomainfrom
move-nightly-whl-to-location

Conversation

@dougyster
Copy link
Collaborator

@dougyster dougyster commented Jan 26, 2026

Motivation

For better organization, nightly whl files are added to the respective cuda version folder instead of the current generic nightly folder in the whl repo. Now, the folder structure is as follows:

cu129/

  • index.html (sglang, sgl-kernel)
  • /sglang (nightly whl)
  • /sgl-kernel (sgl kernel)

The workflow now accepts a cuda python version as a parameter (defaults to cu129)

Modifications

Updated update_nightly_whl_index.py to place whl in the correct position, and auto detect the cuda python version (ie. if cuda-python=13.0, then whls will be placed in cu130)

Accuracy Tests

https://github.com/sgl-project/whl/tree/gh-pages/cu129

Installation of nightly whl works with: pip install sglang==0.5.8.dev0+g0189f41c3 --extra-index-url https://sgl-project.github.io/whl/cu129/

However, there is a hash mismatch for kernel 0.3.21 for x86_64 -
sgl_kernel-0.3.21-cp310-abi3-manylinux2014_x86_64.whl
is outdated or out of sync, and the newest hash is e7f66eb6a149ae2d1ea5a5bc29bc14cbb4322a23952d8d861eedbb253850c90f. This is unrelated to this code change, and someone likely created a new sgl-kernel whl and didn't update the index accordingly.

Benchmarking and Profiling

n/a

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dougyster, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the nightly wheel build process to introduce a more structured and organized repository layout. By dynamically detecting the CUDA version from project dependencies, it ensures that nightly wheel files are placed into dedicated CUDA-specific directories, making it easier to manage and access builds tailored to different CUDA environments. This change primarily affects the automation script responsible for updating the wheel index.

Highlights

  • New Wheel Repository Structure: Nightly wheel files are now organized into CUDA version-specific folders (e.g., cu129/) instead of a single generic nightly/ folder, improving organization.
  • Automated CUDA Version Detection: The update_nightly_whl_index.py script now automatically detects the CUDA Python version from the cuda-python dependency in pyproject.toml to determine the correct folder for wheel placement.
  • Updated Index Generation Logic: The script's logic for generating index.html files has been updated to reflect the new folder structure and ensure proper linking for both sglang and sgl-kernel packages within the CUDA version directory.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the nightly wheel update script to organize wheels into CUDA version-specific folders. The changes include auto-detecting the CUDA version from pyproject.toml and updating the directory structure and index files accordingly. The implementation is solid, but I have one suggestion to improve the robustness of the CUDA version detection.

content = pyproject_path.read_text()

# Match cuda-python==12.9 or cuda-python==13.0, etc.
match = re.search(r'"cuda-python==(\d+)\.(\d+)"', content)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be not right. Since we don't have a pyproject.toml for cuda 130 now...
Is it possible to pass an argument the update_wheel_index function, indicating the version of Cuda?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! Thank you for pointing this out ~

@Fridge003 Fridge003 self-assigned this Jan 26, 2026
@Fridge003 Fridge003 merged commit 51d139b into main Jan 26, 2026
47 of 48 checks passed
@Fridge003 Fridge003 deleted the move-nightly-whl-to-location branch January 26, 2026 16:13
Chen-0210 pushed a commit to Chen-0210/sglang that referenced this pull request Jan 30, 2026
Johnsonms pushed a commit to Johnsonms/sglang that referenced this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants