fix: move nightly whl to cuda version folder#17762
Conversation
Summary of ChangesHello @dougyster, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the nightly wheel build process to introduce a more structured and organized repository layout. By dynamically detecting the CUDA version from project dependencies, it ensures that nightly wheel files are placed into dedicated CUDA-specific directories, making it easier to manage and access builds tailored to different CUDA environments. This change primarily affects the automation script responsible for updating the wheel index. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the nightly wheel update script to organize wheels into CUDA version-specific folders. The changes include auto-detecting the CUDA version from pyproject.toml and updating the directory structure and index files accordingly. The implementation is solid, but I have one suggestion to improve the robustness of the CUDA version detection.
scripts/update_nightly_whl_index.py
Outdated
| content = pyproject_path.read_text() | ||
|
|
||
| # Match cuda-python==12.9 or cuda-python==13.0, etc. | ||
| match = re.search(r'"cuda-python==(\d+)\.(\d+)"', content) |
There was a problem hiding this comment.
This might be not right. Since we don't have a pyproject.toml for cuda 130 now...
Is it possible to pass an argument the update_wheel_index function, indicating the version of Cuda?
There was a problem hiding this comment.
No problem! Thank you for pointing this out ~
Motivation
For better organization, nightly whl files are added to the respective cuda version folder instead of the current generic nightly folder in the whl repo. Now, the folder structure is as follows:
cu129/
The workflow now accepts a cuda python version as a parameter (defaults to cu129)
Modifications
Updated update_nightly_whl_index.py to place whl in the correct position, and auto detect the cuda python version (ie. if cuda-python=13.0, then whls will be placed in cu130)
Accuracy Tests
https://github.com/sgl-project/whl/tree/gh-pages/cu129
Installation of nightly whl works with: pip install sglang==0.5.8.dev0+g0189f41c3 --extra-index-url https://sgl-project.github.io/whl/cu129/
Benchmarking and Profiling
n/a
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci