Skip to content

[diffusion] feat: allow T5's TP Group to reuse the transformer's SP Group #17818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickqian merged 10 commits into from
Feb 5, 2026
Merged

[diffusion] feat: allow T5's TP Group to reuse the transformer's SP Group #17818

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d4ea7c1
[diffusion] feat: allow T5's TP Group to reuse the transformer's SP G…
nono-Sang Jan 27, 2026
e260e74
fix
nono-Sang Feb 4, 2026
7e44509
update
nono-Sang Feb 4, 2026
663c60c
fix
nono-Sang Feb 4, 2026
2af63e2
upd
mickqian Feb 5, 2026
240fc6f
upd
mickqian Feb 5, 2026
8129d41
upd
mickqian Feb 5, 2026
505e332
upd
mickqian Feb 5, 2026
28b153e
upd
mickqian Feb 5, 2026
926df7e
upd
mickqian Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@nono-Sang @mickqian
nono-Sang authored and mickqian committed Feb 5, 2026
commit e260e7403978aef4c36f8eb8729af4aa0c6be76c
1 change: 1 addition & 0 deletions python/sglang/multimodal_gen/runtime/layers/vocab_parallel_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ def __init__(
tp_group = tp_group or get_tp_group()
tp_rank = get_group_rank(tp_group)
self.tp_size = get_group_size(tp_group)
self.tp_group = tp_group
self.num_embeddings = num_embeddings
self.padding_size = padding_size
self.org_vocab_size = org_num_embeddings or num_embeddings
Expand Down
2 changes: 1 addition & 1 deletion python/sglang/multimodal_gen/runtime/models/dits/wanvideo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,7 @@ def forward(
shift, scale = (self.scale_shift_table + temb.unsqueeze(1)).chunk(2, dim=1)

hidden_states = self.norm_out(hidden_states, shift, scale)
hidden_states = self.proj_out(hidden_states)
hidden_states, _ = self.proj_out(hidden_states)

hidden_states = hidden_states.reshape(
batch_size,
Expand Down