Skip to content

[diffusion] comfyui: fix import typo#17834

Merged
mickqian merged 1 commit intosgl-project:mainfrom
triple-mu:triplemu/fix-import-typo
Jan 28, 2026
Merged

[diffusion] comfyui: fix import typo#17834
mickqian merged 1 commit intosgl-project:mainfrom
triple-mu:triplemu/fix-import-typo

Conversation

@triple-mu
Copy link
Contributor

Motivation

Fix import bug:

    from sglang.multimodal_gen.runtime.loader.fsdp_load import (
ImportError: cannot import name 'set_default_dtype' from 'sglang.multimodal_gen.runtime.loader.fsdp_load'

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@github-actions github-actions bot added the diffusion SGLang Diffusion label Jan 27, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @triple-mu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an ImportError that occurred when attempting to import set_default_dtype within the comfyui_qwen_image_pipeline. The change involves correcting the module from which this utility function is imported and updating its name to set_default_torch_dtype in the relevant code. This ensures the proper initialization of default data types during model loading, thereby fixing a critical bug in the multimodal generation runtime.

Highlights

  • Import Correction: Corrected an ImportError by updating the import path for a data type setting function.
  • Function Relocation and Renaming: The function set_default_dtype was replaced with set_default_torch_dtype and is now correctly imported from sglang.multimodal_gen.runtime.loader.utils instead of sglang.multimodal_gen.runtime.loader.fsdp_load.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the ImportError by correctly updating the import path and function name for set_default_dtype to set_default_torch_dtype. The changes are consistent across the import statement and its usage, ensuring the code now correctly references the refactored utility function. This is a clean and necessary fix for the reported bug.

@mickqian
Copy link
Collaborator

@niehen6174 could you take a look?

@BBuf
Copy link
Collaborator

BBuf commented Jan 28, 2026

/tag-and-rerun-ci

@niehen6174
Copy link
Contributor

@niehen6174 could you take a look?

It seems that the imported set_default_dtype function has been modified. I will add some tests for comfyuipipeline later.

@triple-mu triple-mu force-pushed the triplemu/fix-import-typo branch from 7bda1ad to 910de36 Compare January 28, 2026 07:15
@mickqian mickqian merged commit 1d1e72e into sgl-project:main Jan 28, 2026
62 of 64 checks passed
@triple-mu triple-mu deleted the triplemu/fix-import-typo branch January 28, 2026 16:00
charlesHsuGG pushed a commit to charlesHsuGG/sglang that referenced this pull request Jan 30, 2026
Chen-0210 pushed a commit to Chen-0210/sglang that referenced this pull request Jan 30, 2026
sfiisf pushed a commit to sfiisf/sglang that referenced this pull request Feb 5, 2026
Johnsonms pushed a commit to Johnsonms/sglang that referenced this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diffusion SGLang Diffusion run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants