Pass GPU ids to kill specified devices in script.

[hnyls2002]

As the title describes.

[gemini-code-assist]

Summary of Changes

Hello @hnyls2002, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the killall_sglang.sh script by providing more granular control over process termination on GPUs. It introduces the ability to specify individual GPU devices for process cleanup, alongside clarifying the command for a full system GPU process kill. These changes aim to improve the script's flexibility and safety for users managing GPU resources.

Highlights

• Targeted GPU Process Termination: Introduced a new command-line option to kill processes running exclusively on specified GPU devices, identified by their IDs.
• Improved Argument Handling: Refined the script's argument parsing to explicitly require an 'all' argument for terminating all GPU processes, preventing accidental system-wide kills.
• Enhanced Usability: Added comprehensive usage instructions to the script header, detailing the various modes of operation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/pr-test-rust.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new feature to the killall_sglang.sh script, allowing users to terminate processes on specific GPUs by providing their IDs. This is a useful addition for managing GPU resources. However, the implementation contains a critical issue where an invalid list of GPU IDs could cause the script to attempt to kill all processes on the system. I've also included a suggestion to improve the readability and robustness of the code that parses the GPU IDs. Please see the detailed comments below.