[RadixTree][4/N Refactor]: Move available_and_evictable_str to individual radix cache classes#17852
Merged
ispobock merged 4 commits intosgl-project:mainfrom Feb 19, 2026
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
…classes The available_and_evictable_str method is now an abstract method in BasePrefixCache that each radix cache implementation must provide, rather than a generic function in common.py with isinstance checks.
3c78567 to
8b21325
Compare
Collaborator
|
/tag-and-rerun-ci |
hzh0425
approved these changes
Feb 3, 2026
hanming-lu
approved these changes
Feb 3, 2026
ispobock
reviewed
Feb 8, 2026
| def is_tree_cache(self) -> bool: | ||
| return not self.is_chunk_cache() | ||
|
|
||
| def available_and_evictable_str(self) -> str: |
Collaborator
There was a problem hiding this comment.
Could you also test chunk cache (disable radix cache) case?
Collaborator
Author
There was a problem hiding this comment.
--disable-radix-cache
Qwen3-Next-80B-A3B-Instruct mamba
Accuracy: 0.939
Invalid: 0.000
Latency: 69.834 s
Output throughput: 3050.199 token/s
Qwen3-32B full
Accuracy: 0.927
Invalid: 0.000
Latency: 166.645 s
Output throughput: 1167.150 token/s
gpt-oss-120b swa
Accuracy: 0.800
Invalid: 0.052
Latency: 66.569 s
Output throughput: 6632.504 token/s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
The available_and_evictable_str method is now an abstract method in BasePrefixCache that each radix cache implementation must provide, rather than a generic function in common.py with isinstance checks.
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci