fix: ensuring nightly whls are tagged with latest commit#18204
Merged
Kangyan-Zhou merged 1 commit intomainfrom Feb 3, 2026
Merged
fix: ensuring nightly whls are tagged with latest commit#18204Kangyan-Zhou merged 1 commit intomainfrom
Kangyan-Zhou merged 1 commit intomainfrom
Conversation
dougyster
requested review from
Fridge003,
Kangyan-Zhou,
ispobock and
merrymercy
as code owners
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
charlesHsuGG
pushed a commit
to charlesHsuGG/sglang
that referenced
this pull request
Feb 5, 2026
sfiisf
pushed a commit
to sfiisf/sglang
that referenced
this pull request
Feb 5, 2026
RubiaCx
pushed a commit
to RubiaCx/sglang
that referenced
this pull request
Feb 8, 2026
Johnsonms
pushed a commit
to Johnsonms/sglang
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There was a bug where current nightly whls were all tagged with the 0.5.8 tag's hash instead of the latest commit hash at the whl build time. This caused the nightly whls from the past week to overwrite each other, resulting in the siutation below:
Modifications
In the nightly workflow, ensured that each whl was built with the latest commit hash with:
HASH="g$(git rev-parse --short HEAD)"Accuracy Tests
https://github.com/sgl-project/whl/releases/tag/nightly-2026-02-03-8873d972e
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci