Skip to content

[Diffusion] update code owner#18247

Merged
mickqian merged 1 commit intomainfrom
update_diffusion_codeowner
Feb 4, 2026
Merged

[Diffusion] update code owner#18247
mickqian merged 1 commit intomainfrom
update_diffusion_codeowner

Conversation

@BBuf
Copy link
Collaborator

@BBuf BBuf commented Feb 4, 2026

Motivation

#14717

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @BBuf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the .github/CODEOWNERS file to reflect changes in ownership for specific directories related to diffusion and multimodal generation components. It introduces new codeowners for a diffusion-specific JIT kernel path and expands the ownership for existing multimodal generation runtime layers and models, ensuring proper review assignments for these areas.

Highlights

  • New Codeowner for Diffusion JIT Kernel: The .github/CODEOWNERS file has been updated to assign @yingluosanqian, @BBuf, and @mickqian as codeowners for the /python/sglang/jit_kernel/diffusion directory.
  • Expanded Codeowners for Multimodal Generation: @yingluosanqian has been added as a codeowner for the /python/sglang/multimodal_gen/runtime/layers and /python/sglang/multimodal_gen/runtime/models/dits directories.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/CODEOWNERS
    • Added new codeowners (@yingluosanqian, @BBuf, @mickqian) for the /python/sglang/jit_kernel/diffusion path.
    • Updated codeowners for /python/sglang/multimodal_gen/runtime/layers to include @yingluosanqian.
    • Updated codeowners for /python/sglang/multimodal_gen/runtime/models/dits to include @yingluosanqian.
Activity
  • No specific review comments or activity have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CODEOWNERS file to reflect ownership changes for diffusion-related code. The changes are mostly correct, but I've identified an opportunity to improve the ownership consistency. Specifically, some diffusion-related files under jit_kernel are not covered by the new rules. I've provided a suggestion to add explicit ownership for these files to ensure future reviews are routed to the correct team members.

/docker/npu.Dockerfile @ping1jing2 @iforgetmyname
/python/pyproject.toml @merrymercy @Fridge003 @ispobock
/python/sglang/jit_kernel @DarkSharpness @BBuf
/python/sglang/jit_kernel/diffusion @yingluosanqian @BBuf @mickqian
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Based on the provided context files, python/sglang/jit_kernel/timestep_embedding.py and its test file are also part of the diffusion feature set. However, they are not located under the diffusion/ subdirectory and thus won't be covered by this new rule, falling back to the parent directory's owners. To ensure consistent ownership for all diffusion-related code under jit_kernel, consider adding explicit ownership rules for these files as well.

/python/sglang/jit_kernel/diffusion @yingluosanqian @BBuf @mickqian
/python/sglang/jit_kernel/timestep_embedding.py @yingluosanqian @BBuf @mickqian
/python/sglang/jit_kernel/tests/test_timestep_embedding.py @yingluosanqian @BBuf @mickqian

@mickqian mickqian merged commit 2e9d044 into main Feb 4, 2026
44 checks passed
@mickqian mickqian deleted the update_diffusion_codeowner branch February 4, 2026 11:12
charlesHsuGG pushed a commit to charlesHsuGG/sglang that referenced this pull request Feb 5, 2026
RubiaCx pushed a commit to RubiaCx/sglang that referenced this pull request Feb 8, 2026
Johnsonms pushed a commit to Johnsonms/sglang that referenced this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants