-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[Fix] Add lora tied lm head support (for Qwen2.5, Gemma, etc model need) #18634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Fridge003
merged 8 commits into
sgl-project:main
from
yushengsu-thu:fix/lora-tied-lm-head-support
Feb 18, 2026
+313
−4
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1830355
[LoRA] Fix lm_head LoRA on models with tie_word_embeddings and suppor…
yushengsu-thu 3829597
Merge remote-tracking branch 'upstream/main' into fix/lora-tied-lm-he…
yushengsu-thu 418e183
run pre-commit
yushengsu-thu d3fa78c
Update test_lora_tied_lm_head.py
yushengsu-thu f91bbbf
fix review
yushengsu-thu a37f818
Merge remote-tracking branch 'upstream/main' into fix/lora-tied-lm-he…
yushengsu-thu fcb7a69
fx review
yushengsu-thu 824ce5c
Merge remote-tracking branch 'upstream/main' into fix/lora-tied-lm-he…
yushengsu-thu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
run pre-commit
- Loading branch information
commit 418e183aaa8fc7df87a179e0a06435616e464d4c
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.