Skip to content

fix: image version in pypi pr workflow#18735

Merged
ispobock merged 1 commit intomainfrom
fix-pr-pypi
Feb 12, 2026
Merged

fix: image version in pypi pr workflow#18735
ispobock merged 1 commit intomainfrom
fix-pr-pypi

Conversation

@dougyster
Copy link
Collaborator

Motivation

Replacing setuptools_scm with git describe to get accurate image version for pypi pr workflow.

Modifications

See above.

Accuracy Tests

<a href="https://github.com/sgl-project/whl/releases/download/pr-18598-2026-02-12-fec757fd3/sglang-0.5.8.post1.dev9646+pr.18598.gfec757fd3-py3-none-any.whl#sha256=cb3de666ba77589afe54d05dc2eeefa7b032c3d5cdc870e7b35dd6716c3ddfa2">sglang-0.5.8.post1.dev9646+pr.18598.gfec757fd3-py3-none-any.whl</a><br>

from run: https://github.com/sgl-project/sglang/actions/runs/21954091508

Benchmarking and Profiling

n/a

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@ispobock ispobock merged commit e730c72 into main Feb 12, 2026
44 of 45 checks passed
@ispobock ispobock deleted the fix-pr-pypi branch February 12, 2026 16:18
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Johnsonms pushed a commit to Johnsonms/sglang that referenced this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants