[Diffusion] Fix get model name when model local path end with "/"

[Makcum888e]

Motivation

When model path ends with "/" in sglang generate --model-path /local/path/to/model/ get_model_short_name returns empty string: error happens ValueError: Could not find model locally at or SGLang used default sampling params from another model. Usually, autocompletion on Linux systems adds "/".

Modifications

Added check if path ends with "/"

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Follow the SGLang code style guidance.

Review Process

1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
2. Get approvals from CODEOWNERS and other reviewers.
3. Trigger CI tests with comments or contact authorized users to do so.
   • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
4. After green CI and required approvals, ask Merge Oncalls to merge.

[gemini-code-assist]

Summary of Changes

Hello @Makcum888e, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the get_model_short_name utility function. Previously, if a local model path provided to SGLang ended with a forward slash, the function would fail to extract the correct model identifier, leading to ValueError exceptions or the application of incorrect default sampling parameters. The change ensures robust parsing of model paths, improving the reliability of model loading and configuration.

Highlights

• Bug Fix: Addressed an issue in get_model_short_name where model paths ending with a forward slash ('/') would result in an empty string or incorrect model name extraction.
• Path Handling: Implemented a conditional check to properly handle model_id strings that terminate with a '/' character, ensuring the correct short name is returned.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/sglang/multimodal_gen/registry.py
  • Modified get_model_short_name function to correctly handle model IDs that end with a '/' character.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where get_model_short_name returns an empty string for model paths ending with a slash. The proposed change correctly handles single trailing slashes. However, I've identified a case where it fails for multiple trailing slashes and suggested a more robust and simpler implementation. This change will improve the reliability of model path parsing.

[ping1jing2]

/tag-and-rerun-ci

[ping1jing2]

i merge it since Mickqian approved and all UTs passed. please let me know if there are any issues