[sgl] view could hold the memory too long and introduced large memory#19109
Merged
ispobock merged 1 commit intosgl-project:mainfrom Feb 21, 2026
Merged
[sgl] view could hold the memory too long and introduced large memory#19109ispobock merged 1 commit intosgl-project:mainfrom
ispobock merged 1 commit intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Qiaolin-Yu
approved these changes
Feb 21, 2026
Collaborator
|
/tag-and-rerun-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consumption
Motivation
in current maybe_collect_customized_info, v is a batch tensor (B, ...), v[i] takes a view, and when it got put into req.customized_info, req.customized_info will be accumulated until request is finished. since v[i] takes a view, hence the memory can't be released until all the requests in the batch finished. which means this will depend on the longest running request finish to be able to release the memory.
In some situation, when we stored slightly larger info in customized_info, this could accumulate quite large memory, which introduced OOM.
Modifications
suggest to take a copy of v[i] to break the view.
Accuracy Tests
unit test.
Benchmarking and Profiling
N/A
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci