Fix bench_one_batch_server by moving the print statements

[Qiaolin-Yu]

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Follow the SGLang code style guidance.

Review Process

1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
2. Get approvals from CODEOWNERS and other reviewers.
3. Trigger CI tests with comments or contact authorized users to do so.
   • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
4. After green CI and required approvals, ask Merge Oncalls to merge.

[gemini-code-assist]

Summary of Changes

Hello @Qiaolin-Yu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a minor code reorganization in an internal benchmarking script. The change involves relocating several debug print statements to a more logical position within a conditional block, ensuring that diagnostic output related to max_running_requests_per_dp and associated thresholds is displayed only when these variables have been properly initialized. This improves the clarity and context of the logging during benchmark execution.

Highlights

• Code Reorganization: Reordered debug print statements within the run_benchmark_internal function to ensure they are executed only when the relevant variables are defined.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/sglang/test/bench_one_batch_server_internal.py
  • Moved four print statements (for max_running_requests_per_dp, dp_size, skip_max_running_requests_threshold, and skip_token_capacity_threshold) from after the gsp_kwargs definition to inside the if block where skip_max_running_requests_threshold is calculated.

Activity

• No specific activity (comments, reviews, etc.) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Qiaolin-Yu]

/tag-and-rerun-ci

[gemini-code-assist]

Code Review

The pull request correctly addresses a potential NameError in the run_benchmark_internal function when using the vllm backend. By moving the print statements for max_running_requests_per_dp and dp_size into the else block where they are defined, the code avoids attempting to access undefined variables. The logic for calculating and printing benchmark thresholds remains sound for the sglang backend. The fix is straightforward and improves the robustness of the benchmarking script. Note that providing a more descriptive pull request title and description would be beneficial for better change tracking and maintenance.