Decouple statistic and TCPRelay#2872
Merged
celeron533 merged 5 commits intomasterfrom May 6, 2020
unknown repository
Merged
Conversation
ghost
requested review from
Stzx
approved these changes
Apr 30, 2020
celeron533
reviewed
May 4, 2020
| { | ||
| lock (Handlers) | ||
| { | ||
| Handlers.Remove(handler); |
Contributor
There was a problem hiding this comment.
May need to remove all registered events (OnConnected, OnInbound, OnOutbound, OnFailed, OnClosed)
Author
There was a problem hiding this comment.
I don't think so, re-trigger following event after OnClosed won't cause problem.
celeron533
approved these changes
May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
Require translation update
Require document update (readme.md, wikipage, etc)
What is the purpose of your pull request?
Description of your pull request and other information
Using event to update statistic data.