🎂 ForwardProxyView + HotkeysView + OnlineConfigView + VersionUpdatePromptView#2991
Merged
database64128 merged 5 commits intomasterfrom Oct 18, 2020
Merged
🎂 ForwardProxyView + HotkeysView + OnlineConfigView + VersionUpdatePromptView#2991database64128 merged 5 commits intomasterfrom
database64128 merged 5 commits intomasterfrom
Conversation
…omptView - Infrastructure: use one HttpClient instance throughout the lifecycle - Version update: rewrite the update service and add update prompt window - Server sharing: add copy link button - Dependencies: add ReactiveUI.Events.WPF, ReactiveUI.Fody, ReactiveUI.Validation, WPFLocalizeExtension, MdXaml
- Since we now use System.Version, it's no longer needed.
- Thanks @DuckSoft for the review suggestions
- Include localization .dll folders when packaging
chenshaoju
approved these changes
Oct 18, 2020
Collaborator
chenshaoju
left a comment
chenshaoju
left a comment
There was a problem hiding this comment.
The quick test is pass, base appveyor Shadowsocks-4.2.0.78.zip version.
👍 Looks good to me, but someone else must approve.
- Workaround for ElementHost bug
Stzx
reviewed
Oct 18, 2020
Stzx
approved these changes
Oct 18, 2020
Collaborator
|
After 24 hours test, There looks have an issue: Everytime when I start Shadowsocks, the "No available update" message bubble always popup. If I disable IMHO, If not user manually check update then popup "No available update" is no necessity. |
Contributor
Author
@chenshaoju Thanks for the feedback! I'm adding a check to prevent the no available updates pop-up from showing up when it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
Require translation update
Require document update (readme.md, wikipage, etc)
What is the purpose of your pull request?
Description of your pull request and other information
HttpClientinstance throughout the lifecycleReactiveUI.Events.WPF,ReactiveUI.Fody,ReactiveUI.Validation,WPFLocalizeExtension,MdXaml