Skip to content

Commit 83ff408

Browse files
authored
fix(ads): Use the correct AdsLoader AD_ERROR event (#3105)
Listen to the `google.ima.AdErrorEvent.Type.AD_ERROR` event from the IMA SDK AdsLoader instead of the `google.ima.AdEvent.Type.AD_ERROR` in order to properly catch some ad errors that are currently being missed. Closes #3095
1 parent edce189 commit 83ff408

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CONTRIBUTORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ Jacob Trimble <modmaker@google.com>
5050
Jason Palmer <jason@jason-palmer.com>
5151
Jesper Haug Karsrud <jesper.karsrud@gmail.com>
5252
Jesse Gunsch <gunsch@google.com>
53+
Jimmy Ly <jimmyly@google.com>
5354
Joey Parrish <joeyparrish@google.com>
5455
Johan Sundström <oyasumi@gmail.com>
5556
John Bowers <john.bowers@verizondigitalmedia.com>

lib/ads/client_side_ad_manager.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ shaka.ads.ClientSideAdManager = class {
7070
});
7171

7272
this.eventManager_.listen(this.adsLoader_,
73-
google.ima.AdEvent.Type.AD_ERROR, (e) => {
73+
google.ima.AdErrorEvent.Type.AD_ERROR, (e) => {
7474
this.onAdError_( /** @type {!google.ima.AdErrorEvent} */ (e));
7575
});
7676

0 commit comments

Comments
 (0)