fix(ads): Use the correct AdsLoader AD_ERROR event#3105
Merged
michellezhuogg merged 1 commit intoshaka-project:masterfrom Jan 16, 2021
lyjimmy:ad-error-event
Merged
fix(ads): Use the correct AdsLoader AD_ERROR event#3105michellezhuogg merged 1 commit intoshaka-project:masterfrom lyjimmy:ad-error-event
michellezhuogg merged 1 commit intoshaka-project:masterfrom
lyjimmy:ad-error-event
Conversation
Listen to the `google.ima.AdErrorEvent.Type.AD_ERROR` event from the IMA SDK AdsLoader instead of the `google.ima.AdEvent.Type.AD_ERROR` in order to properly catch some ad errors that are currently being missed.
michellezhuogg
approved these changes
Jan 16, 2021
Contributor
michellezhuogg
left a comment
michellezhuogg
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
joeyparrish
pushed a commit
that referenced
this pull request
Jan 25, 2021
Listen to the `google.ima.AdErrorEvent.Type.AD_ERROR` event from the IMA SDK AdsLoader instead of the `google.ima.AdEvent.Type.AD_ERROR` in order to properly catch some ad errors that are currently being missed. Closes #3095
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listen to the
google.ima.AdErrorEvent.Type.AD_ERRORevent from theIMA SDK AdsLoader instead of the
google.ima.AdEvent.Type.AD_ERRORinorder to properly catch some ad errors that are currently being missed.
Resolves #3095