Error importing with CommonJS

[avelad]

Have you read the FAQ and checked for duplicate open issues? Yes

What version of Shaka Player are you using? master as of 2020-05-05

Can you reproduce the issue with our latest release version? No, because v2.5 doesn't the new compiler

Can you reproduce the issue with the latest code from master? Yes

Are you using the demo app or your own custom app? Custom

If custom app, can you reproduce the issue using our demo app? No due Demo app is not using require (CommonJS)

What browser and OS are you using? Any

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

Does not apply

What did you do?

Something like:
const shaka = require('../shaka-player/dist/shaka-player.compiled.js');
console.log(shaka.Player.version);

What did you expect to happen?
Shaka version is shown

What actually happened?

shaka.Player is undefined

[avelad]

Note: in 2.5.x branch the problem does not happen.

[joeyparrish]

I am not able to reproduce using "require" in nodejs, and our integration tests use https://github.com/requirejs/cajon, and those are passing, too.

Here's the exact code I ran in nodejs from the shaka-player working directory with the latest `master:

const shaka = require('./dist/shaka-player.compiled.js');
console.log(shaka.Player.version);

What am I doing differently from you? Are you using a specific module loader I should try?

[joeyparrish]

I hadn't rebuilt the latest, actually. I am able to reproduce now.

[joeyparrish]

The commit which broke the module import was 1076b78, "Unfork Closure base and update the compiler", but the issue seems to stem from this bit of code in an external polyfill:

// Support for CommonJS and AMD module formats.
/** @suppress {undefinedVars} */
(() => {
  if (typeof module !== 'undefined' && module.exports) {
    module.exports = EncryptionSchemePolyfills;
  }
})();

https://github.com/google/eme-encryption-scheme-polyfill/blob/d9c1e681d2bd1a5beb32072d12402270169e7550/index.js#L539-L545

If I edit the compiled bundle and remove the corresponding snippet, the issue disappears.

I don't know yet how the compiler upgrade has influenced the output of that bit of code, nor have I figured out why it's breaking things.

[joeyparrish]

The new compiler outputs this for the export code in the polyfill:

"undefined"!==typeof module&&module.exports&&(module.exports=Ar);

The old compiler output this for the same code:

"undefined"!==typeof module&&module.Ld&&(module.Ld=vr);

So the fact that it didn't break with the old compiler seems to be because of a compiler bug where "module.exports" was renamed to "module.Ld".

[joeyparrish]

Looks like it can be fixed by hiding "module" from the inner part of the bundle, preventing the polyfill's direct export from taking place.

[avelad]

Now, It works but shaka.polyfill is not exported

[joeyparrish]

This might be another artifact of the compiler upgrade. The new one no longer lets us get away with exporting a class member without exporting the class itself. This sounds like an aspect of that. We'll look into it.