Skip to content

TTML </br> tag between spans in a paragraph are not rendered as new lines. #2889

@naasblod

Description

@naasblod

What link can we use to reproduce this?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://e213.cdn.m6web.fr/videos/test_pixel/usp/mb_hd2/subtitle/NCIS-TEARS2_chromecast_unp_sd_dash_v1.ism/Manifest.mpd;panel=CUSTOM%20CONTENT;build=uncompiled

What version of Shaka Player are you using?
v3.0.2, v3.0.3 and v3.0.4

What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36

What did you expect to happen?
</br> should render as new lines between span tags.

<p region="..." begin="..." end="...">
  <span>A text</span>
  <br />
  <span>Another text</span>
</p>

Should render as
A text
Another text

What actually happened?

Are instead rendered as
A text Another text

I think this functionality was added with this pull request and broke in release v3.0.2.

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: archivedArchived and locked; will not be updatedstatus: duplicateA duplicate of another issue; should be closed after linking to the original issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions