Add a missing word in ManifestParser comments#1272
Merged
joeyparrish merged 2 commits intoshaka-project:masterfrom Feb 3, 2018
niklaskorz:patch-3
Merged
Add a missing word in ManifestParser comments#1272joeyparrish merged 2 commits intoshaka-project:masterfrom niklaskorz:patch-3
joeyparrish merged 2 commits intoshaka-project:masterfrom
niklaskorz:patch-3
Conversation
The comment for the definition of `shakaExtern.ManifestParser.PlayerInterface` misses a word, adding it here.
joeyparrish
approved these changes
Feb 3, 2018
Member
|
Thanks! |
hussam-i-am
added a commit
to jwplayer/shaka-player
that referenced
this pull request
Feb 8, 2018
* upstream/master: (87 commits) Turn warnings into errors in jsdoc Make net engine returns error when out of retries Ignore HLS text streams when calculating duration. Fix typo in shakaExterns.Track docs (shaka-project#1274) Fix documentation typos (shaka-project#1272) Support CEA 708 Closed Captions Sort jsdoc tutorials according to the config file Fix jsdoc linksource error on bad markdown escape Improve annotations and docs for PublicPromise Improve annotations and docs for TtmlTextParser Show more verbose functions and records in docs Allow the user to show/hide parts of the docs Update changelog for v2.3.2 Handle UNSUPPORTED_UPGRADE_REQUEST in the demo app Rename Timeline events to include the "Event" suffix (shaka-project#1267) Fix SegmentTemplate w/ duration. Add linksource tag to jsdoc Show jsdoc enum values and allow focus from URL Tweak jsdoc formatting Add jsdoc metadata for interface implementations ...
joeyparrish
pushed a commit
that referenced
this pull request
Feb 12, 2018
* Add a missing word in ManifestParser comments * Fix a typo in a comment in mp4_parser.js
Member
|
Cherry-picked for v2.3.3. |
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment for the definition of
shakaExtern.ManifestParser.PlayerInterfacemisses a word, adding it here.Also fixes a typo in another comment.