Skip to content

Fix french translations#1944

Merged
ismena merged 1 commit intoshaka-project:masterfrom
germain-gg:fix-french-locale
May 15, 2019
Merged

Fix french translations#1944
ismena merged 1 commit intoshaka-project:masterfrom
germain-gg:fix-french-locale

Conversation

@germain-gg
Copy link

Hi,

I've seen that a new version of Shaka Player was mentioned in the Google I/O video about medias. I peeked very quickly at the french locale and saw two things that could be improved with a more idiomatic translation.

"Mettre en veille" means to put your computer to sleep, and not to pause a video.

Thank you for putting together ShakaPlayer and explaining all the updates to Chrome media in that I/O video.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@germain-gg
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ismena
Copy link
Contributor

ismena commented May 15, 2019

Thanks for the PR! We are always happy to have native speaker input for the translations. I'll see if we can work with the Google localization team to improve these for other projects as well <3

Let me run the PR through our test suite.

@shaka-bot
Copy link
Collaborator

All tests passed!

@ismena ismena merged commit a9b24b8 into shaka-project:master May 15, 2019
@ismena
Copy link
Contributor

ismena commented May 15, 2019

All looks good, thanks for contributing!

joeyparrish pushed a commit that referenced this pull request May 20, 2019
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: archived Archived and locked; will not be updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants