Fix french translations#1944
Fix french translations#1944ismena merged 1 commit intoshaka-project:masterfrom germain-gg:fix-french-locale
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Thanks for the PR! We are always happy to have native speaker input for the translations. I'll see if we can work with the Google localization team to improve these for other projects as well <3 Let me run the PR through our test suite. |
|
All tests passed! |
|
All looks good, thanks for contributing! |
Hi,
I've seen that a new version of Shaka Player was mentioned in the Google I/O video about medias. I peeked very quickly at the french locale and saw two things that could be improved with a more idiomatic translation.
"Mettre en veille" means to put your computer to sleep, and not to pause a video.
Thank you for putting together ShakaPlayer and explaining all the updates to Chrome media in that I/O video.