UI: Seek bar doesn't work on iOS#2036
Merged
joeyparrish merged 2 commits intoshaka-project:masterfrom Jul 16, 2019
Merged
Conversation
joeyparrish
approved these changes
Jul 16, 2019
Member
joeyparrish
left a comment
joeyparrish
left a comment
There was a problem hiding this comment.
This looks reasonable to me. We'll want to do some testing on iOS, Android, and ChromeOS touch screens to make sure it's working as expected before we release this.
Collaborator
|
All tests passed! |
AnteWall
pushed a commit
to AnteWall/shaka-player
that referenced
this pull request
Jul 17, 2019
Use touch events to sync the range element's value when the bar is touched. This means you no longer have to touch the tiny ball on the seek bar on iOS. Fixes shaka-project#1918
TheModMaker
pushed a commit
that referenced
this pull request
Jul 19, 2019
Use touch events to sync the range element's value when the bar is touched. This means you no longer have to touch the tiny ball on the seek bar on iOS. Fixes #1918
shaka-bot
pushed a commit
that referenced
this pull request
May 12, 2020
The UI seek bar on touch screen devices was broken in PR #2036 and v2.5.4 - v2.5.11 for live content. VOD content, which starts at 0, was unaffected. This fixes the range calculations for touch events to correctly account for the minimum seek range. Closes #2558 Change-Id: Ic3f6230d88703fd0ea1c9bc15057c0656b1dc42f
joeyparrish
added a commit
that referenced
this pull request
May 13, 2020
The UI seek bar on touch screen devices was broken in PR #2036 and v2.5.4 - v2.5.11 for live content. VOD content, which starts at 0, was unaffected. This fixes the range calculations for touch events to correctly account for the minimum seek range. Closes #2558 Backported to v2.5.x Change-Id: Ic3f6230d88703fd0ea1c9bc15057c0656b1dc42f
github-actions
bot
added
the
status: archived
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1918.
You're able to seek on iOS, but I'm not fully confident yet. Might be a good idea to extend the touchable surface in height in
shaka.ui.RangeElement.